Replies: 1 comment
-
Updating Packet is one of the last major breaking items I had on the to-do list for 0.6, but haven't gotten to it yet as I'm still working through metadata changes. So thanks for being willing to take this on. Historically, the timestamp in Seems like we'll need to have both PTS and DTS fields, and ditch the single TS field. This'll be a breaking change, but 0.6 already breaks a lot, and at least no one will accidentally use the wrong timestamp because we repurposed the old field. For audio packets, I think both the PTS and DTS fields should be populated with the same value. Selectively populating PTS or DTS means making one an This is, of course, if we want to have a On the topic of updates to
One last thing to mention, I will be landing a major change to the MKV reader fairly soon, so it may be worthwhile to prototype this only on MP4 for now. |
Beta Was this translation helpful? Give feedback.
-
There is a need to introduce PTS to the packet structure for proper video handling. Currently, the packet includes TS, which corresponds to DTS.
Options:
I’d like to work on a PR and would appreciate guidance on the desired target state. It’s possible to progress incrementally from option 1 to 2, and then to 3.
Option 1: Requires a small PR and can include separate commits for MKV and MP4.
Option 2: Provides no benefit for audio processing.
Option 3: Clarifies that TS is actually DTS for video packets, but requires changes in many existing applications. If we want this clarity, it’s better to implement it in version 0.6, which is already incompatible with 0.5.
@pdeljanov Please provide your opinion.
Beta Was this translation helpful? Give feedback.
All reactions