Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html direction for rtl locales need to be specified in the localization example #10344

Closed
amiraryan1996 opened this issue Jan 4, 2025 · 2 comments · Fixed by #10345
Closed

html direction for rtl locales need to be specified in the localization example #10344

amiraryan1996 opened this issue Jan 4, 2025 · 2 comments · Fixed by #10345
Labels
area: ui Related to the admin panel.

Comments

@amiraryan1996
Copy link
Contributor

Describe the Bug.

Image

Localization example need an small refactor, detected issue is about the HTML document direction for RTL locales.
For example Arabic language rtl key in locales array is true but document direction stay at default left to right value while we are in Arabic route.

Reproduction Steps

step 1: Run localization example.
step 2: Change locale to Arabic (http://localhost:3000/ar).

Document direction should be right to left but it's in left to right direction.

Environment Info

Binaries:
  Node: 20.9.0
  npm: 10.1.0
  Yarn: N/A
  pnpm: 9.14.2
Relevant Packages:
  payload: 3.14.0
  next: 15.1.3
  @payloadcms/db-mongodb: 3.14.0
  @payloadcms/email-nodemailer: 3.14.0
  @payloadcms/graphql: 3.14.0
  @payloadcms/live-preview: 3.14.0
  @payloadcms/live-preview-react: 3.14.0
  @payloadcms/next/utilities: 3.14.0
  @payloadcms/payload-cloud: 3.14.0
  @payloadcms/plugin-form-builder: 3.14.0
  @payloadcms/plugin-nested-docs: 3.14.0
  @payloadcms/plugin-redirects: 3.14.0
  @payloadcms/plugin-search: 3.14.0
  @payloadcms/plugin-seo: 3.14.0
  @payloadcms/richtext-lexical: 3.14.0
  @payloadcms/translations: 3.14.0
  @payloadcms/ui/shared: 3.14.0
  react: 19.0.0
  react-dom: 19.0.0
Operating System:
  Platform: linux
  Arch: x64
  Version: #49-Ubuntu SMP PREEMPT_DYNAMIC Mon Nov  4 02:06:24 UTC 2024
  Available memory (MB): 15736
  Available CPU cores: 8
@amiraryan1996 amiraryan1996 added area: ui Related to the admin panel. status: needs-triage Possible bug which hasn't been reproduced yet labels Jan 4, 2025
@amiraryan1996 amiraryan1996 mentioned this issue Jan 4, 2025
Merged
paulpopus pushed a commit that referenced this issue Jan 6, 2025
@amiraryan1996
chore(examples): set HTML dir attribute for RTL locales #10344 (#10345)
df827c0 
fix [#10344](#10344)

The template was missing defining direction.

direction property is necessary because HTML direction will be LTR for
RTL languages by default.
@github-actions github-actions bot removed the status: needs-triage Possible bug which hasn't been reproduced yet label Jan 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

🚀 This is included in version v3.15.0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This issue has been automatically locked.
Please open a new issue if this issue persists with any additional detail.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: ui Related to the admin panel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(examples): set HTML dir attribute for RTL locales #10344 amiraryan1996/payload
1 participant
@amiraryan1996