Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix CORS anchor link #10333

Merged
merged 2 commits into from
Jan 6, 2025
Merged

docs: fix CORS anchor link #10333

merged 2 commits into from
Jan 6, 2025
+1 −1

Conversation

Danil0v3s
Copy link
Contributor

@Danil0v3s Danil0v3s commented Jan 3, 2025 •
edited
Loading

What?

Overview CORS anchor seem to be broken and leads nowhere

Why?

Anchors should work

How?

Fixing anchor

Fixes #10332

@Danil0v3s Danil0v3s changed the title fix(docs): CORS anchor link fix(docs): fix CORS anchor link Jan 3, 2025
@Danil0v3s Danil0v3s changed the title fix(docs): fix CORS anchor link docs: fix CORS anchor link Jan 3, 2025
@jacobsfletch
Copy link
Member

Thanks @Danil0v3s! A better way to handle this might actually be to use our custom hash syntax on the heading itself, this way the link itself can remain as #cors which is more concise. It looks something like this:

## Cross-origin resource sharing (CORS)#cors

@Danil0v3s
Copy link
Contributor Author

Thanks @Danil0v3s! A better way to handle this might actually be to use our custom hash syntax on the heading itself, this way the link itself can remain as #cors which is more concise. It looks something like this:

## Cross-origin resource sharing (CORS)#cors

Please see 307e9c8

@jacobsfletch jacobsfletch merged commit fd52de6 into payloadcms:main Jan 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobsfletch jacobsfletch jacobsfletch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve CORS related docs
2 participants
@Danil0v3s @jacobsfletch