Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colorPropsReplacedColors rule - update variable declaration instead of prop value #695

Open
thatblindgeye opened this issue Jul 12, 2024 · 0 comments
Labels
codemod enhancement New feature or request post v6

Comments

@thatblindgeye
Copy link
Collaborator

thatblindgeye commented Jul 12, 2024

Followup based on #691 (comment). We should update the rule so that the fixer updates any var declarations instead of always the prop value. We could use this as an excuse to create some helpers as well for general var updating.

This could involve creating a new helper and using it any other applicable rules.

Required actions:

  1. Build codemod
  2. Build test
  3. Update readme with description & example
@thatblindgeye thatblindgeye added enhancement New feature or request codemod labels Jul 12, 2024
@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues Jul 12, 2024
@tlabaj tlabaj moved this from Needs triage to Ready to assign in PatternFly Issues Aug 8, 2024
@tlabaj tlabaj added this to the Penta final release milestone Aug 8, 2024
@thatblindgeye thatblindgeye removed this from the Penta final release milestone Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codemod enhancement New feature or request post v6
Projects
Status: Ready to assign
Development

No branches or pull requests

2 participants