Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts tokens - dupes in dark CSS #53

Open
mcoker opened this issue May 10, 2024 · 1 comment
Open

Charts tokens - dupes in dark CSS #53

mcoker opened this issue May 10, 2024 · 1 comment

Comments

@mcoker
Copy link
Contributor

mcoker commented May 10, 2024

Looks like all of the charts tokens are output again in tokens-charts-dark.scss, not just the tokens that are different for dark theme compared to tokens-charts.scss. Shouldn't the dark stylesheet only include necessary overrides to the default tokens?

@github-project-automation github-project-automation bot moved this to Needs triage in PatternFly Issues May 10, 2024
@srambach srambach moved this from Needs triage to Not started in PatternFly Issues May 13, 2024
@srambach srambach added this to the Penta alpha omega release milestone May 13, 2024
@srambach
Copy link
Member

I agree, the dark charts stylesheet should only include the overrides.

At a glance, it seems to be something with the structure of the collection in figma and/or the exporter - the dark charts tokens aren't coming with 'dark' as a layer.

Once that's done, the dark charts config might also need to look for charts.dark instead of just charts

@kmcfaul kmcfaul removed this from the Penta final release milestone Aug 28, 2024
@srambach srambach removed the Post v6 label Oct 25, 2024
@mcoker mcoker moved this from Not started to Backlog in PatternFly Issues Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

3 participants