Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer @ bottom of page #14

Open
lorensr opened this issue Dec 22, 2014 · 3 comments
Open

Footer @ bottom of page #14

lorensr opened this issue Dec 22, 2014 · 3 comments
Labels

Comments

@lorensr
Copy link
Member

lorensr commented Dec 22, 2014

If content is shorter than window height, footer should be at bottom of window. Otherwise it should be bottom of content. Couldn't figure out how to do this in CSS. Is it possible? If not, we can do it w/ JS.

@lorensr lorensr added the css label Dec 22, 2014
@lorensr
Copy link
Member Author

lorensr commented Dec 23, 2014

I'm not near a computer but you can do this with css by setting the body's min-height to be 100% of the screen and the footer absolutely positioned at the bottom of the screen. And make sure the body's width is defined at 100% and the position is relative or absolute. Hope this helps!!
-Rennie

Our CSS is a bit complex due to the polymer menu/drawer for small screens

  • making body positioned makes #full-width disappear on small screen
  • adding width: 100% to #full-width makes it unscrollable

My changes:

57a70fa

On pages with a lot of content, the gray footer is in middle:

image

Adding min-height: 100%; to #full-width doesn't help.

Feel free to commit directly to devel branch! Then we can merge into gh-pages when it's in a working state.

@lorensr
Copy link
Member Author

lorensr commented May 4, 2015

@hagata If this is easy. Prior comments were for someone else. Committing to gh-pages is fine.

@lorensr
Copy link
Member Author

lorensr commented Sep 21, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants