Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exercise boxes need to match branding #2

Open
ericelliott opened this issue May 15, 2015 · 5 comments
Open

Exercise boxes need to match branding #2

ericelliott opened this issue May 15, 2015 · 5 comments
Assignees
Labels
Milestone

Comments

@ericelliott
Copy link
Contributor

We have a brand style guide that will help.

@ericelliott ericelliott added this to the 1.0 milestone May 15, 2015
@mhirst
Copy link
Contributor

mhirst commented May 31, 2015

Here they are with matching headers and opposites.

eejs-exercise-blue
eejs-exercise-black
eejs-exercise-blue-black-header
eejs-exercise-black-blue-header

@ericelliott
Copy link
Contributor Author

Nice! I like the black main page header with the blue exercises.

Do you know how to create a pull request to submit your changes for review?

The changes for the exercises will probably need to be made in this file. (assets/eejs.css in the cloned repository.)

To change the look of the page header, you'll need to work in the main repo. I created an issue to address that there.

@mhirst
Copy link
Contributor

mhirst commented May 31, 2015

Cool. I like that one too.

I've created pull requests in the past. Thanks for the tip on the file.

I'll chip away at these this week.

Cheers!

@ericelliott
Copy link
Contributor Author

Awesome. Thank you! =)

@mhirst
Copy link
Contributor

mhirst commented Jun 4, 2015

Where does this file live in the repo?

https://courses.ericelliottjs.com/img/logo.png

I can see it being loaded by the handlebars template, but can't seem to find the "img" directory anywhere.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants