Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

version_update_mask not working as expected #2701

Open
majamassarini opened this issue Jan 20, 2025 · 2 comments
Open

version_update_mask not working as expected #2701

majamassarini opened this issue Jan 20, 2025 · 2 comments
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working.

Comments

@majamassarini
Copy link
Member

I released packit 1.0.0 with version_update_mask set as '\d+.'

Looking at the dashboard everything seems ok, packit seems to be released just for rawhide (and epel):

Image

But then in dist-git do exist PRs even for the other branches (f40, f41...):

Image
@majamassarini majamassarini added kind/bug Something isn't working. area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. labels Jan 20, 2025
@nforro
Copy link
Member

nforro commented Jan 20, 2025

Isn't that because fast_forward_merge_into doesn't care about version?

@majamassarini
Copy link
Member Author

Yes, it could be. But I don't think it is the right behaviour, or do you think the fast_forward_merge_into option should win over the version_update_mask? Now we can merge PRs by mistake.

@majamassarini majamassarini added impact/low This issue impacts only a few users. gain/low This doesn't bring that much value to users. labels Jan 20, 2025
@majamassarini majamassarini moved this from new to priority-backlog in Packit Kanban Board Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/fedora Related to Fedora ecosystem complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/bug Something isn't working.
Projects
Packit Kanban Board
Status: priority-backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@majamassarini @nforro