Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store Project variables #1980

Open
LecrisUT opened this issue Mar 30, 2023 · 2 comments
Open

Store Project variables #1980

LecrisUT opened this issue Mar 30, 2023 · 2 comments
Labels
area/general Related to whole service, not a specific part/integration. complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/feature New feature or a request for enhancement. workaround-exists There is an existing workaround that can be used in the meantime of implementing the issue.

Comments

@LecrisUT
Copy link
Contributor

It would be useful to allow to store some variables and/or secrets in the packit service/dashboard. This requires quite a lot of implementation so we could break it down in a few stages:

  • Store public variables associated with project and have a substitution mechanism (jinja or plain bash?)
  • Set and get variables via the CLI using the fas token (or forge tokens, but that might be too complicated for user)
  • Add user authentication to dashboard.packit.dev and allow them to set/get variables
  • Handle secret variables as well. These could be encrypted using the forge secret, depends a lot on the available APIs, have it symmetric or assymetric? Probably the previous step can narrow down a design

An example usage for this would be in packit#1902.
@TomasTomecek TomasTomecek added complexity/single-task Regular task, should be done within days. workaround-exists There is an existing workaround that can be used in the meantime of implementing the issue. impact/low This issue impacts only a few users. area/general Related to whole service, not a specific part/integration. gain/low This doesn't bring that much value to users. kind/feature New feature or a request for enhancement. labels Apr 13, 2023
@TomasTomecek TomasTomecek moved this from new to backlog in Packit Kanban Board Apr 13, 2023
@lbarcziova lbarcziova self-assigned this Apr 13, 2023
@lbarcziova
Copy link
Member

We have met with Cristian and explained that as for the user authentication and handling secrets via dashboard, we do not want to implement this in any near future, taking our priorities into consideration (we did research on the authenticated dashboard in the past, and the outcome was that the implementation would be quite extensive).

Keeping this issue open to track the storing of the public variables, but this is currently low-prio for us.

@lbarcziova lbarcziova removed their assignment Apr 16, 2023
lbarcziova added a commit to lbarcziova/packit that referenced this issue Jan 4, 2024
@lbarcziova
Return Bodhi update alias and URL when creating one
d9b7ca4 
Related to packit/packit-service#1980
@lbarcziova lbarcziova mentioned this issue Jan 4, 2024
Merged
@majamassarini
Copy link
Member

@LecrisUT is this something still relevant for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/general Related to whole service, not a specific part/integration. complexity/single-task Regular task, should be done within days. gain/low This doesn't bring that much value to users. impact/low This issue impacts only a few users. kind/feature New feature or a request for enhancement. workaround-exists There is an existing workaround that can be used in the meantime of implementing the issue.
Projects
Packit Kanban Board
Status: backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@TomasTomecek @majamassarini @LecrisUT @lbarcziova