Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for domain_hint in upstream parameters for OIDC #310

Open
5 tasks done
jonny-puma opened this issue Dec 12, 2023 · 4 comments
Open
5 tasks done

Support for domain_hint in upstream parameters for OIDC #310

jonny-puma opened this issue Dec 12, 2023 · 4 comments
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.

Comments

@jonny-puma
Copy link

Preflight checklist

Ory Network Project

nostalgic-agnesi-otu9x8e3js

Describe your problem

When logging in with OIDC with Microsoft you can supply a query param called login_hint to select which Azure organization you are logging into. External B2B users in Azure only live in the organzation they are invited to. So if userB from companyB is a guest in companyA, domain_hint needs to be set to login_hint=companyA.com for userB's guest user to be found. This is especially important if the user is memeber of multiple organizations to make sure the correct one is used.

https://learn.microsoft.com/en-us/entra/identity-platform/v2-protocols-oidc

Describe your ideal solution

Add a field in upstream_parameters called domain_hint adding domain hint as a query parameter in the oidc login request.

Workarounds or alternatives

Add the azure organization as a generic oidc provider in ory. We do however prefer to keep all Microsoft OIDC customers in the Microsoft OIDC provider regardless of org. for simplicity.

Version

@ory/kratos-client: ^0.13.1

Additional Context

No response

@jonny-puma jonny-puma added the feat New feature or request. label Dec 12, 2023
@aeneasr
Copy link
Member

aeneasr commented Dec 13, 2023

Hi there, please use the newest version of @ory/client when working with Ory Network :) It should have the parameters you're missing!

@jonny-puma
Copy link
Author

Already implemented, my bad

@jonny-puma
Copy link
Author

jonny-puma commented Dec 14, 2023

I updated the client and tested again. hd, prompt, and login_hint is passed as query parameters, but not domain_hint. Docs does not list domain_hint as supported parameters. Is it maybe reserved because of the organization field in oidc credentials?

@jonny-puma jonny-puma reopened this Dec 14, 2023
Copy link

Hello contributors!

I am marking this issue as stale as it has not received any engagement from the community or maintainers for a year. That does not imply that the issue has no merit! If you feel strongly about this issue

  • open a PR referencing and resolving the issue;
  • leave a comment on it and discuss ideas on how you could contribute towards resolving it;
  • leave a comment and describe in detail why this issue is critical for your use case;
  • open a new issue with updated details and a plan for resolving the issue.

Throughout its lifetime, Ory has received over 10.000 issues and PRs. To sustain that growth, we need to prioritize and focus on issues that are important to the community. A good indication of importance, and thus priority, is activity on a topic.

Unfortunately, burnout has become a topic of concern amongst open-source projects.

It can lead to severe personal and health issues as well as opening catastrophic attack vectors.

The motivation for this automation is to help prioritize issues in the backlog and not ignore, reject, or belittle anyone.

If this issue was marked as stale erroneously you can exempt it by adding the backlog label, assigning someone, or setting a milestone for it.

Thank you for your understanding and to anyone who participated in the conversation! And as written above, please do participate in the conversation if this topic is important to you!

Thank you 🙏✌️

@github-actions github-actions bot added the stale Feedback from one or more authors is required to proceed. label Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request. stale Feedback from one or more authors is required to proceed.
Projects
None yet
Development

No branches or pull requests

2 participants