Focus Indicators and Disabled Buttons and Img Alt

[kelsS]

Hi team! I reviewed the focus indicators for the newest versions of PFE and RHDS and I have some concerns about a few of them. I think these indicators need to be updated to be less subtle. I also have concerns about a specific blue over dark backgrounds that is really difficult and actually painful to look at. I am attaching my screenshots from RHDS only in this discussion. I will start another discussion in the PFE repo for PFE issues.

The dark blue in this image over that dark background is difficult to read and painful to look at.

This seems like a bug with the demo of the table over dark backgrounds. Or we might be missing color styles for tables on dark backgrounds.

For this one, I know that a tooltip pops up when the play button is in focus but it is really difficult to discern that dark blue against the black of the play button.

This component needs to have an empty alt attribute when there is no alt text rather than no alt attr at all.

Disabled buttons should still be tab focusable.

The light blue background for anywhere that a call to action is used is way too subtle and needs to be reworked.

The focus indicator for the brick variant is practically invisible and needs to be reworked.

[marionnegp]

@kelsS, thanks for bringing this up! We're releasing a fix to the focus states for <rh-cta> variants in the upcoming release, which will also help with the issues in <rh-card>. Maybe auditing focus states for other elements and fixing them is something we can add to the next milestone, @markcaron @hellogreg?

[hellogreg]

Yeah, @kelsS and @marionnegp . There's some great stuff in here that may well spawn new issues! I think giving that stuff a look for the next milestone is a fine idea. I know some of those things (e.g., focusable disabled controls) were on Nikki's radar back in the day, too.