Deploy errors are not thrown when main subsidiary language is not english

[omrilit]

Your environment

OS : e.g. iOS Monterey 12.2
Node.js version : 16.14.2
suitecloud-cli version : 1.6.2
Terminal/CMD tool : node js

Describe the bug

When using SDF JS for an account that its main subsidiary is set to a non-english language, e.g. French, and there is a deploy failure, the response doesn't indicate a failure(!).

Although the "*** ERREUR ***" log is printed, the "ActionResult.isSuccess()" returns true.

Since we use SDF using code and we consume the returned "ActionResult" object, we cannot rely on it for non-english account due to this bug.

To Reproduce

1. authenticate an account that its main Subsidiary language is set to French
2. configure an SDF AccountCustomizationProject that has an XML that will yield a deploy failure
3. run project deploy

Actual Behavior

The Deploy will fail but an error will only be logged while ActionResult.isSuccess() === true.

Expected Behavior

The Deploy will fail, an error will be logged and ActionResult.isSuccess() === false.

Additional context

This is very important for us as we rely on the ActionResult.isSuccess() in order to determine whether the deploy request has succeeded or not, and with this issue we tell the user that it always succeeds, although it may have failed.

[lfpvillegas]

Hi @omrilit
Thanks for your message.
We are looking at the issue. We have contacted the team responsible of this error Message and look for a fix.
We would notify you with any update about it.

Thanks

[lfpvillegas]

Hi again @omrilit
I have already talked with the team and they would find a solution. But before, please contact technical support for creating a ticket, so this issue could be tracked properly.

Thanks and Regards