Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for Negative operation #27500

Open
a-sidorova opened this issue Nov 11, 2024 · 16 comments · May be fixed by #28258
Open

[Good First Issue] [ARM]: Implement CPU plugin just-in-time emitter for Negative operation #27500

a-sidorova opened this issue Nov 11, 2024 · 16 comments · May be fixed by #28258
Assignees
Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers platform: arm OpenVINO on ARM / ARM64

Comments

@a-sidorova
Copy link
Contributor

Context

JIT Emitters are part of code generation feature (a.k.a. tensor compiler) that automatically produces highly-efficient optimized fused subgraph binary code. Each emitter implements specific operation from low level OpenVINO dialect.

Currently, Negative op is supported in CPU Plugin as Math op on x64 and ARM platforms. The Math ops use not efficient C++ implementations. The idea is to move Negative op from Math to Eltwise ops which use JIT emitters for the better performance. We already have x64 JIT emitter, so need to implement the same emitter for ARM

Prerequisites

Recommended to use ARM CPU based platform for development (e.g. Mac, Raspberry Pi etc). Emulators (e.g. QEMU) is still an option, but not that convenient, especially for final performance evaluation.

What needs to be done?

Before emitter implementation, please, modify tests to be sure that developed functionality is covered by test:

Tests

Tests are disabled in default build, so ensure to add -DENABLE_TESTS=ON into cmake command.

GoogleTest is used for testing. CPU functional test target is ov_cpu_func_tests. You can use GoogleTest filter:

./bin/[platform]/[build_type]/ov_cpu_func_tests --gtest_filter="*smoke*Activation*Negative*"

Example Pull Requests

Resources

Contact points

@a-sidorova, @dmitry-gorokhov

@a-sidorova a-sidorova added good first issue Good for newcomers category: CPU OpenVINO CPU plugin platform: arm OpenVINO on ARM / ARM64 labels Nov 11, 2024
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Nov 11, 2024
@nashez
Copy link
Contributor

nashez commented Nov 23, 2024

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Nov 25, 2024
@a-sidorova
Copy link
Contributor Author

@nashez Hi! Could you tell me please if you need help with the impl or with something else?

@nashez
Copy link
Contributor

nashez commented Dec 9, 2024

Hi @a-sidorova
Sorry I couldn't get time to work on this yet

I will take it up this weekend

@xyz-harshal
Copy link
Contributor

.take

Copy link
Contributor

Thanks for being interested in this issue. It looks like this ticket is already assigned to a contributor. Please communicate with the assigned contributor to confirm the status of the issue.

@a-sidorova a-sidorova assigned xyz-harshal and unassigned nashez Dec 30, 2024
@a-sidorova
Copy link
Contributor Author

Reassigned the issue to @xyz-harshal since @nashez is not active for a long time

@xyz-harshal good luck!

@xyz-harshal xyz-harshal removed their assignment Dec 30, 2024
Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@xyz-harshal xyz-harshal removed their assignment Dec 30, 2024
@xyz-harshal
Copy link
Contributor

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@xyz-harshal xyz-harshal removed their assignment Jan 1, 2025
@xyz-harshal
Copy link
Contributor

.take

Copy link
Contributor

github-actions bot commented Jan 2, 2025

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@xyz-harshal xyz-harshal removed their assignment Jan 2, 2025
Copy link
Contributor

github-actions bot commented Jan 2, 2025

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@a-sidorova
Copy link
Contributor Author

@xyz-harshal you created the PR with the implementation and removed you assignment in this issue. Could you tell me please if you had some problems? Looks like that your work was almost completed. It would be great if you fully finish it 😃

@geeky33 geeky33 removed their assignment Jan 3, 2025
@xyz-harshal
Copy link
Contributor

.take

Copy link
Contributor

github-actions bot commented Jan 3, 2025

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@a-sidorova a-sidorova moved this from Assigned to In Review in Good first issues Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: CPU OpenVINO CPU plugin good first issue Good for newcomers platform: arm OpenVINO on ARM / ARM64
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

4 participants