From 8a40a5422a26b72171d10d81db80d060790c14ec Mon Sep 17 00:00:00 2001 From: Reuven Gonzales Date: Wed, 3 Jul 2024 09:34:07 -0700 Subject: [PATCH] The assets package is now autoloaded (#1754) * The assets package is now autoloaded * More clean up --- .../contribute/connect-data/bigquery/replication.md | 10 ---------- apps/docs/docs/contribute/connect-data/dagster.md | 8 +++----- apps/docs/docs/contribute/connect-data/gcs.md | 11 ++--------- 3 files changed, 5 insertions(+), 24 deletions(-) diff --git a/apps/docs/docs/contribute/connect-data/bigquery/replication.md b/apps/docs/docs/contribute/connect-data/bigquery/replication.md index ae792f573..8a5245486 100644 --- a/apps/docs/docs/contribute/connect-data/bigquery/replication.md +++ b/apps/docs/docs/contribute/connect-data/bigquery/replication.md @@ -55,16 +55,6 @@ For the latest documentation on configuration parameters, check out the comments in the [BigQuery Data Transfer factory](https://github.com/opensource-observer/oso/blob/main/warehouse/oso_dagster/factories/bq_dts.py). -In order for our Dagster deployment to recognize this asset, -you need to import it in -`warehouse/oso_dagster/assets/__init__.py`. - -```python -... -from .lens import * -... -``` - For more details on defining Dagster assets, see the [Dagster tutorial](https://docs.dagster.io/tutorial). diff --git a/apps/docs/docs/contribute/connect-data/dagster.md b/apps/docs/docs/contribute/connect-data/dagster.md index 9d875715d..44c36d622 100644 --- a/apps/docs/docs/contribute/connect-data/dagster.md +++ b/apps/docs/docs/contribute/connect-data/dagster.md @@ -35,11 +35,9 @@ At a high-level, there are 2 possible pathways: it can lead to performance issues, especially if the data does not easily fit in memory. -Assets should be added to -`warehouse/oso_dagster/assets/` and then imported in -`warehouse/oso_dagster/assets/__init__.py`. -All assets defined in this module are automatically -loaded into Dagster from the main branch of the git repository. +Assets should be added to `warehouse/oso_dagster/assets/`. All assets defined in +this package are automatically loaded into Dagster from the main branch of the +git repository. For an example of a custom Dagster asset, check out the [asset for oss-directory](https://github.com/opensource-observer/oso/blob/main/warehouse/oso_dagster/assets/ossd.py), diff --git a/apps/docs/docs/contribute/connect-data/gcs.md b/apps/docs/docs/contribute/connect-data/gcs.md index d467e8f5e..d5fae11da 100644 --- a/apps/docs/docs/contribute/connect-data/gcs.md +++ b/apps/docs/docs/contribute/connect-data/gcs.md @@ -69,15 +69,8 @@ For the latest documentation on configuration parameters, check out the comments in the [GCS factory](https://github.com/opensource-observer/oso/blob/main/warehouse/oso_dagster/factories/gcs.py). -In order for our Dagster deployment to recognize this asset, -you need to import it in -`warehouse/oso_dagster/assets/__init__.py`. - -```python -from .dbt import * -from .gitcoin import * -... -``` +In order for our Dagster deployment to recognize this asset, you must ensure +that it is a python file in the directory `warehouse/oso_dagster/assets/`. For more details on defining Dagster assets, see the [Dagster tutorial](https://docs.dagster.io/tutorial).