Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove/Update examples using deprecated library constants #506

Closed
kwaters4 opened this issue Dec 13, 2023 · 2 comments
Closed

Remove/Update examples using deprecated library constants #506

kwaters4 opened this issue Dec 13, 2023 · 2 comments
Assignees
@kwaters4
Milestone
OpenSHMEM 1.6

Comments

@kwaters4
Copy link
Contributor

kwaters4 commented Dec 13, 2023 •
edited
Loading

Currently two examples still use the deprecated shmem library constants of SHMEM_REDUCE_SYNC_SIZE and SHMEM_REDUCE_MIN_WRKDATA_SIZE

The examples are located in the following files:

  1. Within the Atomicity Guarantees located in ./example_code/amo_scenario_3.c
  2. The example forSHMEM_CTX_DESTROY located in ./example_code/shmem_ctx.c
@jdinan jdinan added this to the OpenSHMEM 1.6 milestone Dec 14, 2023
@jdinan
Copy link
Collaborator

jdinan commented Sep 26, 2024

@kwaters4 Do you still want to make this change for OpenSHMEM 1.6?

@kwaters4
Copy link
Contributor Author

@jdinan Both active set based example updates were captured in the following merge requests:

#528
#538

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwaters4 kwaters4

Labels
None yet
Projects
None yet
Milestone
OpenSHMEM 1.6
Development

No branches or pull requests
2 participants
@jdinan @kwaters4