Wrong command in ./01_install_requirements.sh script

[mnietoji]

+(./01_install_requirements.sh:102): yq -iy '.[3].dnf.nobest = "true"' /home/dev-scripts/metal3-dev-env/vm-setup/roles/packages_installation/tasks/centos_required_packages.yml
Error: unknown shorthand flag: 'y' in -y
Usage:
yq eval [expression] [yaml_file1]... [flags]

This line is wrong
yq -iy '.[3].dnf.nobest = "true"' ${METAL3_DEV_ENV_PATH}/vm-setup/roles/packages_installation/tasks/centos_required_packages.yml

[mnietoji]

yq --version
yq (https://github.com/mikefarah/yq/) version v4.40.5

[mnietoji]

I have seen that yq -iy works with yq 3.2.3 but fails with yq 4.40.5, but i think v4 is being installed here:
dev-scripts/metallb/deploy_operator.sh:go install -mod='' github.com/mikefarah/yq/[email protected]

[bdlink]

yq v3 has not been supported since 2021, need to check all places yq is used and make sure they work for yq v4.18.1 and later versions.

[bdlink]

Issue here seems to be that yq 3.4.3 (which is installed by the script) is not installed if another version is already present. removing the offending option -y does not work, because later uses of yq will fail (as incompatable with yq v4).

[elfosardo]

just left a comment in the related PR:
I beleive the latest available version in pypi is still 3.x
I'd rather pin yq version installed so when the new version comes out we don't break dev-scripts

[elfosardo]

this should help #1668
when 4.x is available on pypi we can think about updating the command