Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ngx_cache_purge module #110

Closed
skhattane opened this issue Jun 18, 2019 · 6 comments
Closed

Adding ngx_cache_purge module #110

skhattane opened this issue Jun 18, 2019 · 6 comments

Comments

@skhattane
Copy link

Hi guys,

I need to add the nginx_cache_module (for cache invalidation) to openresty.
I try to build it from source as mentioned in the README with the "RESTY_CONFIG_OPTIONS_MORE" argument.

Here is my command :
docker build --build-arg RESTY_CONFIG_OPTIONS_MORE=--add-module=../extension/ngx_cache_purge-2.3 -t openresty -f xenial/Dockerfile .

Here is the error

./configure: error: no ../extension/ngx_cache_purge-2.3/config was found
ERROR: failed to run command: sh ./configure --prefix=/usr/local/openresty/nginx \...

There is a config file in the extension folder.
Any ideas ?

I downloaded the extension from http://labs.frickle.com/files/

@neomantra
Copy link
Member

You need to get those ngx_cache_purge files into the build environment in order for the build steps to see them. They are on your host but not in Docker.

One way is to modify the Dockerfile and use an ADD stanza...

Or you can download it (e.g. using curl) as a RESTY_EVAL_PRE_CONFIGURE step.

@agentzh
Copy link
Member

agentzh commented Jun 19, 2019

The cache purge module is no longer maintained. We surely won't want to include it in our official images by default.

@neomantra
Copy link
Member

I wasn't considering adding it to the official image. Also, I'm going to seek more parity with the upstream builds via #109

But, the images do give customization options for people to do whatever they want.. and it is these image build options (for their own builds, not our official Travis) which give a lot of flexibility. They should be able to get it to work -- assuming the module itself isn't broken.

@neomantra
Copy link
Member

Closing this as we aren't adding it and you haven't asked for more help. Feel free to re-open if you make progress and have still have questions on how to include it in your own builds.

@adityapatadia
Copy link

@agentzh this module is now nicely maintained. It would make sense to add this: https://github.com/torden/ngx_cache_purge

@agentzh
Copy link
Member

agentzh commented Sep 23, 2020

@adityapatadia We generally don't add modules that we haven't tested the compatibility ourselves. Unless you can guarentee it is fully supported in our test matrix: http://qa.openresty.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants