Help wanted! Add code.* attributes to controller spans

[trask]

Capture code.namespace and code.function on controller and view spans.

Controller spans:

• dropwizard/dropwizard-views-0.7
• grails-3.0
• jaxrs/jaxrs-1.0
• jaxrs/jaxrs-2.0/jaxrs-2.0-annotations
• jaxrs/jaxrs-3.0/jaxrs-3.0-annotations
• jaxrs/jaxrs-common
• jaxws/jaxws-2.0-axis2-1.6
• jaxws/jaxws-common
• jaxws/jaxws-cxf-3.0
• jaxws/jaxws-jws-api-1.1
• jaxws/jaxws-metro-2.2
• jsf/jsf-mojarra-1.2
• jsf/jsf-mojarra-3.0
• jsf/jsf-myfaces-1.2
• jsf/jsf-myfaces-3.0
• play/play-mvc/play-mvc-2.4
• ratpack/ratpack-1.4
• spring/spring-webflux/spring-webflux-5.0
• spring/spring-webmvc/spring-webmvc-common Add code attributes to spring webmvc controller spans #12839
• spring/spring-ws-2.0
• struts-2.3
• tapestry-5.4
• vaadin-14.2

View spans:

• jsp-2.3
• spring/spring-webmvc/spring-webmvc-common

[arik-dig]

@trask I can take this task and start with JAX-RS Controllers and Spring-MVC Controllers.
Do I have your blessing?

[trask]

👍

[arik-dig]

@trask sorry, but seems that due to time constraints I won't be able to address it soon.

[SylvainJuge]

Also please note that code.namespace and code.function are currently in the process of becoming part of the stable semantic conventions:

• promotion to release candidate for code.* attributes mark code.* attributes as release candidate semantic-conventions#1599
• renaming code.function to code.function.name rename some code attributes semantic-conventions#1624

It should not prevent anyone contributing by capturing code.function, it just means that contributions here are even more likely to contribute to the stability of those attributes and that some follow-up PRs are expected in the affected areas once those attributes are stable.

[jaydeluca]

was there a mechanism/script used to generate the list of instrumentations that need this? I noticed a few that I looked at might already be done (jaxrs for example). I can update the list as I look through them, but wanted to see if there was some automated detection method used or if the list was generated some other way