-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling debug symbols #58
Enabling debug symbols #58
Comments
Are there performance penalties in having debug symbols enabled? |
Yes, I would like to implement the feature in the builder in a backward-compatible way as it suggested in #63 (comment) , but I have no idea who and how use releases issued from this repository. We make private builds of the collector using the builder. I could update builder manifests here too if it would be helpful for users of those releases. |
Generally speaking, no. Debug symbols are used by debugging facilities in cases they required to, for example when a user attach or run process under a debugger or the Linux perf tool. The only effect everyone who don't care about debugging should notice is the growth of the binary size. |
I believe the only place you'd need to change is this:
|
I don't see, how it would help binaries built using the OpenTelemetry builder command line tool. |
Sorry, I missed that part!
This would be the place to remove it: I think we can externalize it in a config property. |
I think this issue is still relevant today. Looking at the builder code, we can override ld flags only when debug compilation property is set to true. Is there a way to only override ld flags? The purpose here is to keep debug symbols and DWARF data without setting those GCflags. |
We are contemplating whether to enable debug symbols (disabled by -s -w LDFLAGS on build) on our downstream repo
aws-otel-collector
. We want to be in line with what is being done upstream but it seems that there's an inconsistency. In thisopentelemetry-collector-releases
repo it appears that they are disabled but in opentelemetry-collector-contrib it appears to be enabled.Is there any reason for this inconsistence/any guidance on what we should lean towards regarding enabling/disabling debug symbols?
The text was updated successfully, but these errors were encountered: