Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DebugExporter] Add EventName from LogRecord to output #11967

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

[DebugExporter] Add EventName from LogRecord to output #11967

wants to merge 15 commits into from
+69 −0

Conversation

cijothomas
Copy link
Member

Description

  1. Adds event name from LogRecord to debug exporter.
  2. Also modified the example config file to include logs too. (It only had traces/metrics). Not really required for this change, but hope that is okay to club into same PR!

Link to tracking issue

Fixes #11966

Testing

Manually tested with Otel client that exported a LogRecord with event name and without event name.

(1st time contributor here, still learning the process.)

@cijothomas cijothomas requested review from andrzej-stencel and a team as code owners December 20, 2024 19:24
cijothomas
cijothomas commented Dec 20, 2024
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@codecov Codecov
Copy link

codecov bot commented Dec 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.62%. Comparing base (b4ae0ba) to head (ec90084).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #11967   +/-   ##
=======================================
  Coverage   91.62%   91.62%           
=======================================
  Files         447      447           
  Lines       23737    23739    +2     
=======================================
+ Hits        21749    21751    +2     
  Misses       1613     1613           
  Partials      375      375

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member Author

@codeboten The changelog CI check looks broken, unrelated to this PR. Could you help fix that, so this PR can have its CI check pass.

andrzej-stencel
andrzej-stencel approved these changes Jan 2, 2025
View reviewed changes
Copy link
Member

@andrzej-stencel andrzej-stencel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Cijo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codeboten codeboten codeboten left review comments

@trask trask trask left review comments

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@TylerHelmuth TylerHelmuth Awaiting requested review from TylerHelmuth TylerHelmuth is a code owner automatically assigned from open-telemetry/collector-approvers

@bogdandrutu bogdandrutu Awaiting requested review from bogdandrutu

@dmitryax dmitryax Awaiting requested review from dmitryax

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add EventName to DebugExporter output for Logs
4 participants
@cijothomas @trask @codeboten @andrzej-stencel