-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] [cmd/builder] pin ocb go.mod template to 1.22.0 #11845
base: main
Are you sure you want to change the base?
[chore] [cmd/builder] pin ocb go.mod template to 1.22.0 #11845
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11845 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 447 447
Lines 23739 23739
=======================================
Hits 21751 21751
Misses 1613 1613
Partials 375 375 ☔ View full report in Codecov by Sentry. |
@jackgopack4 thanks! This should also fix an issue when CI starts failing once a new patch version of go is released: |
Please rebase so we can merge this |
I'm not sure this is the best way to fix it; it would require anyone running OCB to use go 1.22.0; apparently (linked in the issue) 1.22 is actually a valid go.mod but it was something that was broken then fixed in a recent version of both 1.22 and 1.23. That's why I left this as a draft |
#11844 (comment) I think this is not an issue, but we do need to add documentation to let users know that a newer subversion, either any version of 1.23, 1.22.4+, or 1.21.11+ |
Description
pins go.mod in ocb template to 1.22.0 to match latest Golang standard (golang/go#62278)
Link to tracking issue
Fixes #11844
Testing
pipeline tests should suffice
Documentation
none, bugfix