Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider replacing use of SiteID with simply an Entity index #252

Open
mxgrey opened this issue Dec 26, 2024 · 0 comments
Open

Consider replacing use of SiteID with simply an Entity index #252

mxgrey opened this issue Dec 26, 2024 · 0 comments

Comments

@mxgrey
Copy link
Collaborator

mxgrey commented Dec 26, 2024

The prevalence of SiteID throughout the site format/editor implementation and its similarity to builtin Bevy entities forces a significant amount of brittle machinery on our implementation.

The main blocker that prevents us from moving away from SiteID is the fact that if we serialize raw entity indexes then those indexes could clash if we load multiple sites into the same application simultaneously.

To move away from SiteID we would need to choose either:

  1. Do not support loading multiple sites now or ever
  2. Use a multi-world implementation so that each site is loaded as its own world

I find option (1) very unappealing since there could be legitimate reasons for a user to load multiple sites into the same application at the same time. Future features that we haven't thought of yet may benefit from this capability.

Option (2) is more appealing but I'm not clear on its feasibility at the moment. The last I checked, multi-world applications are not well supported yet in Bevy and there is ongoing work in Bevy's roadmap to support them better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant