Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed ping_host_add() adds disfunctional pinger #43

Open
ghost opened this issue Jan 28, 2019 · 0 comments
Open

Failed ping_host_add() adds disfunctional pinger #43

ghost opened this issue Jan 28, 2019 · 0 comments

Comments

@ghost
Copy link

ghost commented Jan 28, 2019

I've tried running simple code using liboping and it fails to run as non-root with "Operation not permitted" returned from ping_host_add() on latest Ubuntu. Which is expected unless we have sufficient permissions via CAP_NET_*.

Despite ping_host_add() returning "Operation not permitted" the host is apparently added to the pingobj_t nevertheless - at least ping_iterator_count() returns incremented number.

Which later on causes following error:
liboping.c:1419: ping_send: Assertion max_fd != -1' failed.`
which results in SIGABRT.

That's with liboping0 v1.10.0-2 installed from the repo.

I do believe that if ping_host_add() returns error than host shouldn't be added to avoid this sort of confusions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants