Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Four tailwindcss binaries downloaded (for all {linux,macos}-{arm64,x86} combinations) #2871

Open
wikku opened this issue Dec 17, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@wikku
Copy link
Contributor

wikku commented Dec 17, 2024

#2765 was supposed to fix this with some trick.
If dune build is done in the tools/tailwindcss directory, only the correct build is downloaded.
But from the project root directory all four are downloaded.

Tested with dune 3.16 and 3.17.

$ dune bu --verbose
[...]
Actual targets:        
- alias @@default
Running[1]: (cd _build/default/tool/tailwind && /usr/bin/curl -sLO https://github.com/tailwindlabs/tailwindcss/releases/download/v3.3.6/tailwindcss-linux-arm64)
Running[2]: (cd _build/default/tool/tailwind && /usr/bin/curl -sLO https://github.com/tailwindlabs/tailwindcss/releases/download/v3.3.6/tailwindcss-linux-x64)
Running[3]: (cd _build/default/tool/tailwind && /usr/bin/curl -sLO https://github.com/tailwindlabs/tailwindcss/releases/download/v3.3.6/tailwindcss-macos-arm64)
Running[4]: (cd _build/default/tool/tailwind && /usr/bin/curl -sLO https://github.com/tailwindlabs/tailwindcss/releases/download/v3.3.6/tailwindcss-macos-x64)
@github-project-automation github-project-automation bot moved this to 📋 Backlog in OCaml.org Dec 17, 2024
@cuihtlauac cuihtlauac added the bug Something isn't working label Dec 19, 2024
@cuihtlauac
Copy link
Collaborator

Yes, you are right @wikku. PR #2765 did not do the job, I was mistaken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 📋 Backlog
Development

No branches or pull requests

2 participants