Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad timezone test #43

Open
jamesjer opened this issue Dec 13, 2024 · 0 comments
Open

Bad timezone test #43

jamesjer opened this issue Dec 13, 2024 · 0 comments

Comments

@jamesjer
Copy link

My timezone is currently Mountain Standard Time (UTC - 7). Running the test suite fails on a timezone test:

ASSERT gap g6 Local = gap g6 UTC + gap UTC Local
File "tests/test_timezone.ml", line 37, character 2:
FAIL gap g6 Local = gap g6 UTC + gap UTC Local

   Expected: `11'
   Received: `-13'

(gap g6 Local) is -13, which make_in_bounds converts to 11. But (gap g6 UTC) is -6 and (gap UTC Local) is -7, so their sum is indeed -13. The test should do the equivalent of calling make_in_bounds on the result of the addition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant