Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

various improvements #109

Open
wants to merge 59 commits into
base: master
Choose a base branch
from
Open

various improvements #109

wants to merge 59 commits into from

Conversation

obfusk
Copy link
Owner

@obfusk obfusk commented Dec 24, 2024 •
edited
Loading

fixes #28
fixes #45
fixes #55
fixes #58
fixes #67
fixes #80
fixes #88
fixes #91

  • improve validation
  • update test APKs
  • update manpage and changelog
  • update README

obfusk added 24 commits December 22, 2024 00:12
@obfusk
use DIFF_JSON variable
2b5ac9c
@obfusk
add legacy options (still unused for now)
89393a0
@obfusk
add extract_v1_sig() etc. & split off various functions for reuse
b9ab22a
@obfusk
use new v1_sig format
6e0b051
@obfusk
drop support for Python 3.7
b3e1c6e
@obfusk
cleanup
92778e8
@obfusk
update test
9d2d269
@obfusk
validate ZIP headers
623f10d
@obfusk
CI: test legacy
b9150fe
@obfusk
CI: fix
469f1f5
@obfusk
check v1 signature entries are at end of archive
d2eeb09
@obfusk
only check v1 at end of archive when v2 is present; refactor
1943038
@obfusk
extract_v1_sig(): fix return value when there are no entries
f161164
@obfusk
support v1 signature after manifest (fixes #80, improves #88)
9662ad7
@obfusk
README++ [skip ci]
fdc17a9
@obfusk
put zfe_size in v1signature.zip, refactor, update CI
8c9f485
@obfusk
do_patch() fix handling missing v2/v3 signature
1667505
@obfusk
copy_apk() use max comment size of 65536 for seek just in case
fd142b9
@obfusk
put JSON w/ offsets in v1signature.zip & refactor (fixes #88)
40a2d72
@obfusk
add (legacy) to docstrings [skip ci]
3866cc0
@obfusk
use raw docstrings for those w/ doctests [skip ci]
4b5257a
@obfusk
compare: check SHA-256 & add --no-check-{signature,sha256}
90df1ce
@obfusk
clean up doctests (rm imports)
85b2011
@obfusk
fix legacy tests & use --no-check-sha256
e36db7b
@obfusk obfusk self-assigned this Dec 24, 2024
@obfusk obfusk changed the title v1 signature improvements various improvements Dec 24, 2024
@obfusk
Copy link
Owner Author

obfusk commented Dec 25, 2024

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@obfusk obfusk

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@obfusk