Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Clarify feature_negotiation dependency of tls_v1 #86

Open
CodingMinds opened this issue Sep 11, 2023 · 0 comments
Open

docs: Clarify feature_negotiation dependency of tls_v1 #86

CodingMinds opened this issue Sep 11, 2023 · 0 comments

Comments

@CodingMinds
Copy link

According to the protocol implementation the TLS upgrade is only applied if feature negotiation is enabled as well.
This should be highlighted in the protocol documentation.

Related source: https://github.com/nsqio/nsq/blob/master/nsqd/protocol_v2.go#L392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@CodingMinds