Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text labels for theme toggle buttons #231

Open
tseykovets opened this issue Jan 5, 2025 · 0 comments
Open

Text labels for theme toggle buttons #231

tseykovets opened this issue Jan 5, 2025 · 0 comments

Comments

@tseykovets
Copy link

The theme toggle buttons in the settings do not have a text labels. This is an accessibility issue and creates inconvenience for users of assistive technologies such as screen readers.

It would be nice if these buttons to have text labels.

When the design does not allow adding text inside a button, you can add invisible text labels using the aria-label attribute, for example:

<button aria-label="Light"></button>
<button aria-label="Sepia"></button>
<button aria-label="Night"></button>

This will solve this issue. However, if the interface will support multiple languages, these labels should be included in the translation resources, like all other interface strings.

For more details see:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant