Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When iconsDir doesn't exist, live reload silently fails #260

Open
madcampos opened this issue Dec 20, 2024 · 1 comment · May be fixed by #259
Open

When iconsDir doesn't exist, live reload silently fails #260

madcampos opened this issue Dec 20, 2024 · 1 comment · May be fixed by #259

Comments

@madcampos
Copy link

What version of astro-icon are you using?

v1.1.4

Astro Info

Astro                    v4.16.17
Node                     v22.11.0
System                   Windows (x64)
Package Manager          npm
Output                   static
Adapter                  none
Integrations             @vite-pwa/astro-integration
                         @astrojs/sitemap
                         astro-icon

If this issue only occurs in one browser, which browser is a problem?

N/A

Describe the Bug

  1. Load the project on Windows (it works on Mac, haven't tested on Linux)
  2. Delete the iconsDir folder
  3. Run astro dev
  4. Change any css file
  5. Live reload does not work

What's the expected result?

Live reload should be working

Link to Minimal Reproducible Example

https://stackblitz.com/edit/github-mdp6dwwp
@madcampos madcampos linked a pull request Dec 20, 2024 that will close this issue
Open
@fnngttrt
Copy link

Can confirm that the same issue happens on Linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FIX: throw error when local iconDir fails to load madcampos/astro-icon
2 participants
@madcampos @fnngttrt