Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: NocoDB node's "Get Many" does not respect limit below 10 #12338

Closed
miteshashar opened this issue Dec 21, 2024 · 2 comments
Closed

Bug: NocoDB node's "Get Many" does not respect limit below 10 #12338

miteshashar opened this issue Dec 21, 2024 · 2 comments
Labels
in linear Issue or PR has been created in Linear for internal review

Comments

@miteshashar
Copy link

Bug Description

The NocoDB node's "Get Many" operation has an option to limit the number of rows fetched.

If I set it to anything below 10, it does not respect the value and returns 10 rows.

In tables that have many columns(and I need all/most of them) or contain binary files, that tends to make the workflow memory consumption high. That is not desirable, specially when I am fine with loading lesser number of rows.

Just for reference, I already checked #2866 & #3022. They are different.

To Reproduce

  1. Add a NocoDB node with action "Get many rows".
  2. Select the requisite options with "Limit" set as any number below 10.
  3. Test the node.
  4. There are 10 rows returned in output.

Expected behavior

The node should return rows equivalent to the set limit.

Operating System

Ubuntu Server 24.04.1 LTS

n8n Version

1.72.1

Node.js Version

20.18.0

Database

PostgreSQL

Execution mode

queue

@Joffcom
Copy link
Member

Joffcom commented Dec 21, 2024

Hey @miteshashar,

We have created an internal ticket to look into this which we will be tracking as "N8N-7998"

@Joffcom Joffcom added the in linear Issue or PR has been created in Linear for internal review label Dec 21, 2024
@miteshashar miteshashar changed the title Bug: NocoDB node's "Get Many" does not respect limit below 2 Bug: NocoDB node's "Get Many" does not respect limit below 10 Dec 21, 2024
@Joffcom
Copy link
Member

Joffcom commented Jan 3, 2025

Hey @miteshashar,

I have taken a look and when calling the API outside of n8n with the NocoDB API it also returns 10 items so it looks like this may not be an issue with n8n directly.

curl -X 'GET' \
  'https://nocodb.domain.com/api/v2/tables/ID/records?viewId=VIEWID&limit=2&shuffle=0&offset=0' \
  -H 'accept: application/json' \
  -H 'xc-token: AUTH_TOKEN'

I have found this open issue on the NocoDB project for this exact issue: nocodb/nocodb#9513 it looks like once the fix has been released on their side this will start working again. As this is not an issue on our side at the moment I am going to mark this as closed, Let me know if you have any questions on this one.

@Joffcom Joffcom closed this as not planned Won't fix, can't repro, duplicate, stale Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in linear Issue or PR has been created in Linear for internal review
Projects
None yet
Development

No branches or pull requests

2 participants