Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

::merge remaining issues #90

Open
1 of 2 tasks
maowtm opened this issue Jan 9, 2022 · 3 comments
Open
1 of 2 tasks

::merge remaining issues #90

maowtm opened this issue Jan 9, 2022 · 3 comments

Comments

@maowtm
Copy link
Contributor

maowtm commented Jan 9, 2022 •
edited
Loading

  • Avoid using shell escape (proposed to create a dedicated binary)
  • Use deterministic mount paths to make caching work - currently because of the random mount path nothing inside merge can be cached.
@maowtm maowtm mentioned this issue Jan 9, 2022
Merged
@thevirtuoso1973
Copy link
Contributor

@maowtm Is nested merge supported, or handled some way? e.g. (run_literal::merge)::merge.

Currently seems to hang indefinitely after attempting to build with a nested merge, maybe something related to imagegen.

@maowtm
Copy link
Contributor Author

maowtm commented Jan 30, 2022 •
edited
Loading

it should do nothing, as if there is only one outer merge. Hanging is definitely a bug. Investigating.

@maowtm maowtm mentioned this issue Jan 30, 2022
Merged
@maowtm
Copy link
Contributor Author

maowtm commented Jan 30, 2022

done

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@thevirtuoso1973 @maowtm