Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

SemVer semantic: 7.0.0-rc1 > 6 #161

Open
maowtm opened this issue Mar 5, 2022 · 2 comments
Open

SemVer semantic: 7.0.0-rc1 > 6 #161

maowtm opened this issue Mar 5, 2022 · 2 comments
Assignees

Comments

@maowtm
Copy link
Contributor

maowtm commented Mar 5, 2022

Currently semver_geq("7.0.0", "6") is true but semver_geq("7.0.0-rc1", "6") is false (due to the semver crate always returning false when comparing pre-release with non-pre-releases). Need fix.

@maowtm maowtm self-assigned this Mar 5, 2022
@maowtm
Copy link
Contributor Author

maowtm commented Mar 5, 2022

This may actually require either finding another semver crate or writing our own semver implementation... So before we move on @mechtaev can we discuss the exact semantic we want for semver_*...?

@mechtaev
Copy link
Collaborator

mechtaev commented Mar 5, 2022

The official website has a specification: https://semver.org/. I have not seen anything there that forbids comparing pre-release with non-pre-releases, so it seems like a bug to me.

@Foalfloater66 Foalfloater66 self-assigned this Apr 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants