Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow split logging within a single runnable (ie., "consensus" and "etcd" should be distinguishable) #95

Closed
leoluk opened this issue Dec 9, 2021 · 2 comments
Labels
c/dev-ux c/node Issues related to low-level node services and startup c/ux End-user (cluster operator or user) experience enhancements enhancement New feature or request

Comments

@leoluk
Copy link
Member

leoluk commented Dec 9, 2021

See title - I've found myself confused reading the logs until I realized that this was etcd log output, not our own code.

Should we just call it by its name and name it "etcd"?

@q3k
Copy link
Contributor

q3k commented Dec 14, 2021

The reason it's called consensus is to actually separate the wrapping service/runnable (consensus) from the etcd daemon itself. The proble is more that we're logging both these codebases into the same supervisor-provided logging target, making it difficult to pick apart each one.

I wanted to actually fix it by making etcd log into a sub-element of the logtree, but I haven't gotten around to doing that yet.

I'll then extend this issue to implement the possibility of logging into 'fake' runnables, or somehow else decoupling logging targets from the supervision subtree.

Tangentially related to #85 .

@q3k q3k changed the title Rename "consensus" service to "etcd" Allow split logging within a single runnable (ie., "consensus" and "etcd" should be distinguishable) Dec 14, 2021
@q3k q3k added c/dev-ux c/node Issues related to low-level node services and startup c/ux End-user (cluster operator or user) experience enhancements enhancement New feature or request labels Dec 14, 2021
@q3k
Copy link
Contributor

q3k commented Mar 21, 2023

Fix for etcd/consensus logging: https://review.monogon.dev/c/monogon/+/1356

@q3k q3k closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/dev-ux c/node Issues related to low-level node services and startup c/ux End-user (cluster operator or user) experience enhancements enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants