Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wallet] no stdout flush on wallet creation #9655

Open
tankf33der opened this issue Dec 26, 2024 · 1 comment
Open

[wallet] no stdout flush on wallet creation #9655

tankf33der opened this issue Dec 26, 2024 · 1 comment

Comments

@tankf33der
Copy link

versions: - 0.18.3.3 and 0.18.3.4

I can repeat this ONLY on Alpine Linux 3.20, 3.21 (musl!).

Manjaro (ArchLinux) is OK!!!

https://asciinema.org/a/50bn1StLcSCY90zmBJsI0QT1V

No output for "Confirm password:" and it is tricky to complete a wallet creation wizard.

diff --git a/src/common/password.cpp b/src/common/password.cpp
index e6dff95ea..c0edf7a78 100644
--- a/src/common/password.cpp
+++ b/src/common/password.cpp
@@ -185,7 +185,7 @@ namespace
         return false;
       if (verify)
       {
-        std::cout << "Confirm password: ";
+        std::cout << "Confirm password: " << std::flush;
         if (!read_from_tty(pass2, hide_input))
           return false;
         if(pass1!=pass2)
@tankf33der
Copy link
Author

tankf33der commented Dec 26, 2024

Patched version works on Alpine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant