Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Synonym Sync: synonym_case_diff_* variations amongst multiple templates #742

Open
joeflack4 opened this issue Dec 27, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@joeflack4
Copy link
Contributor

joeflack4 commented Dec 27, 2024

Overview

In #720, I introduced changes to the synonym_case_diff_mondo and synonym_case_diff_source columns, to now show |-delimited capitalization variations. However, there is an exception where not all variations will be listed: when the variations show up in different templates.

Examples

Example: MONDO:0023273 pigmented dermatofibrosarcoma protuberans NCIT:C9430
mondo-edit.obo:

id: MONDO:0023273
synonym: "Pigmented Dermatofibrosarcoma Protuberans" RELATED [MESH:D018223]
synonym: "Pigmented dermatofibrosarcoma protuberans" RELATED [GARD:0009624, UMLS:C0334464]
synonym: "pigmented dermatofibrosarcoma protuberans" EXACT [NCIT:C9430]

ncit.owl:

<owl:Class rdf:about="http://purl.obolibrary.org/obo/NCIT_C9430">
    <oboInOwl:hasExactSynonym>Pigmented Dermatofibrosarcoma Protuberans</oboInOwl:hasExactSynonym>
    <oboInOwl:hasExactSynonym>Pigmented dermatofibrosarcoma protuberans</oboInOwl:hasExactSynonym>

Result:
synonym_case_diff_mondo in the first row doesn't show all variations.

mondo_id synonym_scope_source synonym_scope_mondo synonym_case_diff_mondo source_id case
MONDO:0023273 oio:hasExactSynonym pigmented dermatofibrosarcoma protuberans NCIT:C9430 confirmed
MONDO:0023273 oio:hasExactSynonym oio:hasRelatedSynonym Pigmented Dermatofibrosarcoma Protuberans|Pigmented dermatofibrosarcoma protuberans|pigmented dermatofibrosarcoma protuberans NCIT:C9430 updated
MONDO:0023273 oio:hasExactSynonym oio:hasRelatedSynonym Pigmented Dermatofibrosarcoma Protuberans|Pigmented dermatofibrosarcoma protuberans|pigmented dermatofibrosarcoma protuberans NCIT:C9430 updated

Has more columns / easier to read: example.csv

Possible solutions

a. Ignore; minor edge case and not super important.
b. I don't think this will come for free with #725, but I could do it then. I would need to move the capitalization variation logic to happen before the template data frames are created.

@joeflack4 joeflack4 self-assigned this Dec 27, 2024
@joeflack4 joeflack4 added the bug Something isn't working label Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant