Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

play-1.js: raw.githubusercontent.com no longer works for ogg-js files #23

Open
joaocc opened this issue Sep 1, 2017 · 2 comments
Open

Comments

@joaocc
Copy link

joaocc commented Sep 1, 2017

When stf=='js', the current default URL (https://raw.githubusercontent.com/gleitz/midi-js-soundfonts/gh-pages/FluidR3_GM) fails, with an error saying that it doesn't allow execution of JS for something returned as mime text.
The solution we found was to replace the server with https://rawgit.com/gleitz/midi-js-soundfonts/gh-pages/FluidR3_GM which seems to return a more suitable mime type.

More info here ( https://github.com/rgrove/rawgit/blob/master/FAQ.md ).

moinejf added a commit that referenced this issue Sep 1, 2017
The new URL is smaller than the previous one.
I don't know if this commit fixes the issue #23.
@moinejf
Copy link
Owner

moinejf commented Sep 1, 2017 via email

@joaocc
Copy link
Author

joaocc commented Sep 1, 2017

We tested yesterday but used "//" instead of "http://".
If you are having problems, can you pls test with either "//" or "https://"?
Also, it wouldn't hurt to remove the trailing "/", to keep things equal.

moinejf added a commit that referenced this issue Sep 3, 2017
(remove trailing '/' and change http:// to https://)

For issue #23.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants