Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

play-1.js: add support for speedup ratio #22

Open
joaocc opened this issue Aug 31, 2017 · 4 comments
Open

play-1.js: add support for speedup ratio #22

joaocc opened this issue Aug 31, 2017 · 4 comments

Comments

@joaocc
Copy link

joaocc commented Aug 31, 2017

This one is quite simple to explain.
We would like to be able to speed up / slow down the playback by a factor of N. This could be made available to users via a slider.

After reading through play-1.js, it seems that the only way to do it now is to redo the abc conversion with a different BPM setting.
Something like "set_speed_factor" with a float (<1 == slowdown, >1 == speedup) would be great.

Thanks

@moinejf
Copy link
Owner

moinejf commented Sep 1, 2017 via email

@joaocc
Copy link
Author

joaocc commented Sep 1, 2017

You are correct. Sorry for the mixup. Will remove the comment to prevent misleading link.

joaocc added a commit to highskillz/abc2svg that referenced this issue Sep 2, 2017
@joaocc
Copy link
Author

joaocc commented Sep 2, 2017

Not sure if this is the most elegant way to implement this, but we tried to keep changes to a minimum.

@moinejf
Copy link
Owner

moinejf commented Sep 2, 2017

I already implemented such a function in a previous player and I was about to code it.
(your proof of concept does not work because the realtime origin must be shifted)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants