-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass configuration into functions instead of loading internally #696
Labels
enhancement
New feature or request
Comments
9 tasks
teneightfive
added a commit
that referenced
this issue
Jul 28, 2020
This change extracts the handling of rendering assessment answers within another component, for example, a list of panels with a tag into another presenter. This will allow it to be shared by other parts of the app and give the ability to present the assessment answers in separate ways more easily. This change does still contain a style of loading settings internally that we would like to get rid of (see #696) as the refactor would be a much bigger and more time consuming change at this stage.
teneightfive
added a commit
that referenced
this issue
Jul 29, 2020
This change extracts the handling of rendering assessment answers within another component, for example, a list of panels with a tag into another presenter. This will allow it to be shared by other parts of the app and give the ability to present the assessment answers in separate ways more easily. This change does still contain a style of loading settings internally that we would like to get rid of (see #696) as the refactor would be a much bigger and more time consuming change at this stage.
teneightfive
added a commit
that referenced
this issue
Jul 29, 2020
This change extracts the handling of rendering assessment answers within another component, for example, a list of panels with a tag into another presenter. This will allow it to be shared by other parts of the app and give the ability to present the assessment answers in separate ways more easily. This change does still contain a style of loading settings internally that we would like to get rid of (see #696) as the refactor would be a much bigger and more time consuming change at this stage.
teneightfive
added a commit
that referenced
this issue
Jul 29, 2020
This change extracts the handling of rendering assessment answers within another component, for example, a list of panels with a tag into another presenter. This will allow it to be shared by other parts of the app and give the ability to present the assessment answers in separate ways more easily. This change does still contain a style of loading settings internally that we would like to get rid of (see #696) as the refactor would be a much bigger and more time consuming change at this stage.
teneightfive
added a commit
that referenced
this issue
Jul 29, 2020
This change extracts the handling of rendering assessment answers within another component, for example, a list of panels with a tag into another presenter. This will allow it to be shared by other parts of the app and give the ability to present the assessment answers in separate ways more easily. This change does still contain a style of loading settings internally that we would like to get rid of (see #696) as the refactor would be a much bigger and more time consuming change at this stage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Currently we load configuration into modules locally. This makes them hard to test and sometimes hard to follow.
An example can be seen in the discussion on #686.
Possible solution
Pass configuration into each function call separately. This will mean refactoring controllers and presenters a substantial amount but will make things easier to follow and test.
Example:
The text was updated successfully, but these errors were encountered: