You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As part of the new design for move and person pages the routing has been constructed so that the root of those apps redirects to match the first "tab". Each tab is currently a separate route, mostly due to wanting to reduce unnecessary calls which would need to be made if all of this content was displayed on one page and using JavaScript to show/hide tabs.
The question has been raised whether this is the best approach and whether it would make more sense to serve the first tab as the base route.
Currently:
/person/:id/ # redirect to /person/:id/personal-details
/person/:id/personal-details # renders first tab
/person/:id/moves # renders another tab
/move/:id/ # redirect to /person/:id/warnings
/move/:id/warnings # renders first tab
/move/:id/timeline # renders another tab
...
Possibly alternative:
/person/:id/ # renders first tab
/person/:id/moves # renders another tab
/move/:id/ # renders first tab
/move/:id/timeline # renders another tab
...
This would also tie into a suggestion from @ElizabethGoddard that we should remove the tab name from the breadcrumb (see screenshot):
Another added benefit is we don't need to worry about changing the redirect route if the tab names/links change. (Of course, this could also be made to be more dynamic too but this would be extra work)
The text was updated successfully, but these errors were encountered:
Issue/question
As part of the new design for move and person pages the routing has been constructed so that the root of those apps redirects to match the first "tab". Each tab is currently a separate route, mostly due to wanting to reduce unnecessary calls which would need to be made if all of this content was displayed on one page and using JavaScript to show/hide tabs.
The question has been raised whether this is the best approach and whether it would make more sense to serve the first tab as the base route.
Currently:
Possibly alternative:
This would also tie into a suggestion from @ElizabethGoddard that we should remove the tab name from the breadcrumb (see screenshot):
Another added benefit is we don't need to worry about changing the redirect route if the tab names/links change. (Of course, this could also be made to be more dynamic too but this would be extra work)
The text was updated successfully, but these errors were encountered: