Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggesting a different approach #1

Open
axelhzf opened this issue Jan 12, 2019 · 0 comments
Open

Suggesting a different approach #1

axelhzf opened this issue Jan 12, 2019 · 0 comments

Comments

@axelhzf
Copy link

axelhzf commented Jan 12, 2019

I was reading the whole conversation here facebook/create-react-app#982
and I wanted to propose a different solution but the issue was closed. So I thought that this would be a good place to follow the conversation (sorry if that is not the case).

I tried a different approach here https://github.com/axelhzf/create-react-app-docker-environment-variables
the main idea is to build the application at build time and only replace the environment variables at runtime. The environment variables are replaced on the index.html defining a global variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant