Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative file link in Terminal not clickable #237086

Open
unional opened this issue Dec 30, 2024 · 2 comments
Open

Relative file link in Terminal not clickable #237086

unional opened this issue Dec 30, 2024 · 2 comments
Assignees

Comments

@unional
Copy link

unional commented Dec 30, 2024

Does this issue occur when all extensions are disabled?: Yes

Version: 1.96.2 (user setup)
Commit: fabdb6a
Date: 2024-12-19T10:22:47.216Z
Electron: 32.2.6
ElectronBuildId: 10629634
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Windows_NT x64 10.0.22631

Steps to Reproduce:

The integrated terminal file link works for absolute path (e.g.: /usr/x/proj/_snapshot/snapshot-1.png),
and relative files that are not ignored (e.g.: src/index.ts).

But if the file/folder is gitignored (e.g.: ./_snapshot/snapshot-1.png while _snapshot is ignored in .gitignore),
it doesn't work (clicking on shows No matching results)

Originally asked in: https://discord.com/channels/470167643710816277/1320179380315623494/1320179380315623494

@Astabol
Copy link

Astabol commented Dec 30, 2024

Hello, It's not reproducible from my side. Kindly provide a screenshot or sort video to have on the same page.

Used: d4de5ce

Thanks

@unional
Copy link
Author

unional commented Dec 30, 2024

Is this screenshot, the Expected: __vis__/local/client/expect/to_match_image_snapshot.spec.tsx/fails-when-the-image-is-different-beyond-failure-threshold-in-pixels.png is clicked:

Image

You can see on the right side the file is there (and is opened).

If I commented out **/__vis__/local in the .gitignore, it works:

Image

Here is the project I used for these snapshots: https://github.com/repobuddy/storybook-addon-vis/tree/state2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants