Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom switch-case indentation for JavaScript #235085

Open
xmedeko opened this issue Dec 3, 2024 · 6 comments · May be fixed by #237069
Open

Support custom switch-case indentation for JavaScript #235085

xmedeko opened this issue Dec 3, 2024 · 6 comments · May be fixed by #237069
Assignees
@mjbvz
Labels
feature-request Request for new features or functionality formatting Source formatter issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities javascript JavaScript support issues
Milestone
Backlog

Comments

@xmedeko
Copy link
Contributor

xmedeko commented Dec 3, 2024 •
edited
Loading

Feature request microsoft/TypeScript#18682 and PR #179670 added typescript.format.indentSwitchCase setting, so as it's possible to no-indent case in switch command. Unfortunately, it works for TypeScript only.

Please, add make it work for JavaScript, too. E.g. add some javascript.format.indentSwitchCase setting.

Note: See also #32925 which was originally created for JavaScript, but closed as completed, while in fact it's not completed, because the current implementation is for TypeScript only.
@xmedeko xmedeko mentioned this issue Dec 3, 2024
Closed
@jrieken jrieken assigned mjbvz and unassigned jrieken Dec 3, 2024
@mjbvz mjbvz added help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors feature-request Request for new features or functionality labels Dec 3, 2024
@vs-code-engineering vs-code-engineering bot added this to the Backlog Candidates milestone Dec 3, 2024
@vs-code-engineering VS Code Engineering
Copy link

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@samuelpwlim
Copy link

Hi, would I be able to try out this issue?

@a-pav
Copy link

a-pav commented Dec 7, 2024

@samuelpwlim Right now, it's not even in the backlog, so not implemented yet.
It needs at least 20 up-votes to be considered for implementation. So please promote it if you can!

@mjbvz mjbvz added javascript JavaScript support issues formatting Source formatter issues labels Dec 12, 2024
@akhilk2802
Copy link

I want to work on this

@karuna-jain
Copy link

karuna-jain commented Dec 24, 2024 •
edited
Loading

I want to work on it

@vs-code-engineering VS Code Engineering
Copy link

🙂 This feature request received a sufficient number of community upvotes and we moved it to our backlog. To learn more about how we handle feature requests, please see our documentation.

Happy Coding!

@aslezar aslezar linked a pull request Dec 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
feature-request Request for new features or functionality formatting Source formatter issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities javascript JavaScript support issues
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

feat: support custom js switch-case indentation aslezar/vscode
7 participants
@xmedeko @jrieken @mjbvz @a-pav @akhilk2802 @samuelpwlim @karuna-jain