Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libxcrypt] crypt-bcrypt.c: Fix Werror=strict-overflow with GCC 4.8.5 #43021

Conversation

WangWeiLin-MV
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV commented Dec 31, 2024

Fix #42978, error with Werror=strict-overflow

Submit upstream besser82/libxcrypt#197, backport besser82/libxcrypt@7fc1531 to fix.

Checklist

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Test

The port installation tests pass with the following triplets:

  • x64-linux (GNU 4.8.5 and GNU 14.2.0)

@WangWeiLin-MV WangWeiLin-MV added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Dec 31, 2024
@WangWeiLin-MV WangWeiLin-MV changed the title [libxcrypt] Fix Werror=strict-overflow [libxcrypt] crypt-bcrypt.c: Fix Werror=strict-overflow with GCC 4.8.5 Dec 31, 2024
@WangWeiLin-MV WangWeiLin-MV force-pushed the ports/libxcrypt/warning-strict-overflow branch from 5ed3b56 to e7d0aa7 Compare December 31, 2024 01:27
@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review January 2, 2025 01:41
@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Jan 2, 2025
@BillyONeal BillyONeal merged commit a25bd22 into microsoft:master Jan 2, 2025
17 checks passed
@BillyONeal
Copy link
Member

Thanks!

@WangWeiLin-MV WangWeiLin-MV deleted the ports/libxcrypt/warning-strict-overflow branch January 3, 2025 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libxcrypt] Build error on x64-linux
3 participants