Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert.AreEqual/AreNotEqual string overloads that have CultureInfo parameters are incorrectly annotated #4468

Open
Youssef1313 opened this issue Dec 29, 2024 · 0 comments
Open

Assert.AreEqual/AreNotEqual string overloads that have CultureInfo parameters are incorrectly annotated #4468

Youssef1313 opened this issue Dec 29, 2024 · 0 comments
Labels
Area: Assertion

Comments

@Youssef1313
Copy link
Member

  1. The CultureInfo parameter for such overloads is annotated as nullable incorrectly. A null value isn't currently allowed and we will throw when we have null.
  2. When we get null, we throw AssertFailedException, but I think ArgumentNullException is a better fit. It's not really that the assert is failing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Assertion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Youssef1313