MSTEST0037 testing operators == and !=

[avivanoff]

If you have a class that overloads operators == and !=, writing the proper unit tests results in MSTEST0037: Use proper 'Assert' methods:

public sealed class SomeClass
{
    public static Boolean operator ==(SomeClass left, SomeClass right)
    {
        ...
    }

    public static Boolean operator !=(SomeClass left, SomeClass right)
    {
        ...
    }
}

[TestMethod]
public void SomeClass_TestOperatorEquals()
{
var left = new SomeClass(...);
var right = new SomeClass(...);
Assert.IsTrue(laft == right); // MSTEST0037
}

[Youssef1313]

Thanks for reporting this.

This was explicitly mentioned in the analyzer docs. But I think the analyzer could be improved.

[avivanoff]

@Evangelink, @Youssef1313, are the fixes in preview packages? 3.7.1-preview.25052.3 still has the issue.

[Evangelink]

@avivanoff fix wasn't backported yet, I have done it now: #4511.

It should be available on any version from 3.7.1-preview.25054.6

[avivanoff]

Tested with 3.7.1-preview.25054.10, looks good.

[Youssef1313]

Thank you for confirming @avivanoff!