junit: allow user to reset Browser after each test #1692
Conversation
| closeBrowserContext(); | ||
| if(options.closeBrowserAfterEachTest != null && options.closeBrowserAfterEachTest) { | ||
| BrowserExtension.closeBrowser(); |
There was a problem hiding this comment.
The behavior of closing the browser (rather than just the context) after each test is very specific to BrowserStack implementation and they could solve it better by providing an API for explicitly marking test start/end instead of binding it to the lifetime of the browser connection.
I'd rather the clients, that need to close browsers after each test, implemented their own fixture and just called browser.close() after each test from the fixture. We can add onDisconnect handler to all browser instances that are created via Playwright fixture and clean-up thread local cache when the event is fired. It would also cover the case when the user calls browser.close() in the middle of a test too, so it's something that would make sense to do in any case.
Do you think such approach would make more sense or you'd still prefer to have the option?
|
|
||
| public enum Trace { | ||
| OFF, | ||
| ON, | ||
| RETAIN_ON_FAILURE; | ||
| } | ||
|
|
||
| public Options setCloseBrowserAfterEachTest(Boolean closeBrowser) { |
There was a problem hiding this comment.
If we proceed with this option, let's have a test for it.
|
going to close this PR and open a new one with the changes we discussed in #1691 |
Resolves #1691