You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Playwright Typescript has ability to specify which browsers to install, but Java version does not. Of course I can work around it with calling install separately and skipping download with Java. However, that would mean adding another Gradle task to build system and I rather avoid that since in my opinion framework really should have this built-in as an option for easier use.
Rather than another environment variable I think it would be nicer to have explicit option in CreateOptions; it seems like a simpler and easier thing. Internally, it is still and environment variable so the method signatures don't have to be changed.
For example:
The text was updated successfully, but these errors were encountered:
msiemczyk
added a commit
to msiemczyk/playwright-java
that referenced
this issue
Jun 12, 2023
Of course I can work around it with calling install separately and skipping download with Java.
This is how we handle browser installation in all other languages and we'd rather switch java to the same mode. Actually we also consider replacing automatic driver extraction with a manual step (see #1268 for more context) in which case it would make sense to download browsers in the same step.
Playwright Typescript has ability to specify which browsers to install, but Java version does not. Of course I can work around it with calling install separately and skipping download with Java. However, that would mean adding another Gradle task to build system and I rather avoid that since in my opinion framework really should have this built-in as an option for easier use.
Rather than another environment variable I think it would be nicer to have explicit option in CreateOptions; it seems like a simpler and easier thing. Internally, it is still and environment variable so the method signatures don't have to be changed.
For example:
The text was updated successfully, but these errors were encountered: