Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add ability to specify which browsers to install #1302

Closed
msiemczyk opened this issue Jun 12, 2023 · 2 comments
Closed

[Feature] Add ability to specify which browsers to install #1302

msiemczyk opened this issue Jun 12, 2023 · 2 comments

Comments

@msiemczyk
Copy link

Playwright Typescript has ability to specify which browsers to install, but Java version does not. Of course I can work around it with calling install separately and skipping download with Java. However, that would mean adding another Gradle task to build system and I rather avoid that since in my opinion framework really should have this built-in as an option for easier use.

Rather than another environment variable I think it would be nicer to have explicit option in CreateOptions; it seems like a simpler and easier thing. Internally, it is still and environment variable so the method signatures don't have to be changed.

For example:

image

msiemczyk added a commit to msiemczyk/playwright-java that referenced this issue Jun 12, 2023
@yury-s
Copy link
Member

yury-s commented Jun 13, 2023

Of course I can work around it with calling install separately and skipping download with Java.

This is how we handle browser installation in all other languages and we'd rather switch java to the same mode. Actually we also consider replacing automatic driver extraction with a manual step (see #1268 for more context) in which case it would make sense to download browsers in the same step.

@msiemczyk
Copy link
Author

Fair enough, if you think that is not desired you can reject the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants