Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

De-emphasize @message_handler, in favor of more specific decorators #4828

Open
jackgerrits opened this issue Dec 27, 2024 · 1 comment
Open

De-emphasize @message_handler, in favor of more specific decorators #4828

jackgerrits opened this issue Dec 27, 2024 · 1 comment
Labels
needs-triage proj-core
Milestone
0.4.1

Comments

@jackgerrits
Copy link
Member

jackgerrits commented Dec 27, 2024 •
edited
Loading

Suggest @event, and @rpc instead.

The semantics of these two kinds of handlers differ enough such that we should strongly suggest users pick one specifically
@jackgerrits jackgerrits added this to the 0.4.0 milestone Dec 27, 2024
@jackgerrits jackgerrits changed the title Deprecate @message_handler Deprecate @message_handler, in favor of more specific decorators Dec 27, 2024
@ekzhu
Copy link
Collaborator

ekzhu commented Dec 27, 2024

Let's make the changes throughout our repo but should keep the deprecating notice well into 0.4.x. This decorator has been there for a long time.

@jackgerrits jackgerrits modified the milestones: 0.4.0, 0.4.1 Jan 2, 2025
@jackgerrits jackgerrits changed the title Deprecate @message_handler, in favor of more specific decorators De-emphasize @message_handler, in favor of more specific decorators Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-triage proj-core
Projects
None yet
Milestone
0.4.1
Development

No branches or pull requests
2 participants
@ekzhu @jackgerrits