Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The hope is to support internal streaming returns in the agent, with the utility functions returning non-empty values. #4825

Open
zhangwei668 opened this issue Dec 27, 2024 · 5 comments

Comments

@zhangwei668
Copy link

What feature would you like to be added?

I want to inherit the agent module and rewrite create as create_stream. However, this causes issues with tool usage, resulting in empty returns. The reason for this is that the create and create_stream methods in the OpenAIChatCompleteClient class are written inconsistently.

Why is this needed?

The hope is to support internal streaming returns in the agent, with the utility functions returning non-empty values.

@ekzhu
Copy link
Collaborator

ekzhu commented Dec 27, 2024

We are working on streaming support in an existing issue. #3862

If that one meets your need, let's close this issue as duplicate

@KnSup
Copy link

KnSup commented Jan 13, 2025

I'm confused about the issue mentioned in #3862. What I currently need is the effect of using await self._model_client.create_stream in on_messages_stream. However, it seems that await self._model_client.create is being used now. This results in information being returned to the user only after each agent has finished running, which is not a good user experience.

@ekzhu
Copy link
Collaborator

ekzhu commented Jan 13, 2025

The issue mentioned is exactly to use the run_stream API like create_stream. Could you let us know what is the confusion?

@KnSup
Copy link

KnSup commented Jan 13, 2025

run_stream allows me to obtain the information after each Agent has finished executing, but it doesn't provide the streaming output content like create_stream does.

@ekzhu
Copy link
Collaborator

ekzhu commented Jan 13, 2025

You are right -- this is exactly what we are working on in the issue mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants