Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong footnotes conversion for bibliography item #142

Open
Intelligent2013 opened this issue Apr 18, 2022 · 5 comments
Open

Wrong footnotes conversion for bibliography item #142

Intelligent2013 opened this issue Apr 18, 2022 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@Intelligent2013
Copy link
Contributor

Intelligent2013 commented Apr 18, 2022

Source STS xml:

<ref content-type="standard" id="ref_1">
	<label>[1]</label>
	<std>
		<std-ref>ISO 9001:2015</std-ref>
		<xref ref-type="fn" rid="fn_3">
			<sup>3</sup>
		</xref>
		<fn id="fn_3">
			<label>3</label>
			<p> Supersedes ISO 9001:2008.</p>
		</fn>, <title>Quality management systems — Requirements</title>
	</std>
</ref>

Current adoc:

* [[[ISO_9000_2015,ISO 9000:2015]]] footnote:[Supersedes ISO 9000:2005.], _Quality management systems — Fundamentals and vocabulary_ 

Expected adoc (move footnote inside reference's text):

* [[[ISO_9000_2015,(ISO 9000:2015 footnote:[Superseded by ISO 9000:2005.])ISO 9000:2015]]], _Quality management systems — Fundamentals and vocabulary_ 
@Intelligent2013 Intelligent2013 added the bug Something isn't working label Apr 18, 2022
@Intelligent2013 Intelligent2013 self-assigned this Apr 18, 2022
@Intelligent2013 Intelligent2013 moved this to Triage in Metanorma Apr 18, 2022
@Intelligent2013
Copy link
Contributor Author

Actually there isn't issue in markup. Current adoc is correct, it encoded similar to adoc from mn-samples-iso repository:

* [[[ISO16634,ISO 16634:--]]] footnote:[Under preparation. (Stage at the time of publication ISO/DIS 16634)], _Cereals, pulses, milled cereal products, oilseeds and animal feeding stuffs -- Determination of the total nitrogen content by combustion according to the Dumas principle and calculation of the crude protein content_

but in the presentation xml there isn't element <note format="text/plain" type="Unpublished-Status">. I'll create a ticket.

Repository owner moved this from Triage to Done in Metanorma Apr 18, 2022
Repository owner moved this from Done to In Progress in Metanorma Apr 18, 2022
@Intelligent2013
Copy link
Contributor Author

If bibliographic item contains footnote, then it should be converted to:

[[ISO_9000_2015]]
[%bibitem]
=== _Quality management systems — Fundamentals and vocabulary_
docid::
id::: ISO 9000:2015
type:: standard
biblionote:: 
type::: Unpublished-Status
content::: Superseded by ISO 9000:2005.

otherwise relaton overwrites all data after [[[ISO_9000_2015,ISO 9000:2015]]]

@ronaldtse
Copy link
Contributor

ronaldtse commented Apr 18, 2022

@Intelligent2013 I believe this is correct? Are you seeing otherwise? That would be a bug if so.

https://www.metanorma.org/author/topics/document-format/bibliography/#localities
Screenshot 2022-04-18 at 10 05 13 PM

* [[[ISO_9000_2005,(ISO 9000:2005 footnote:[Superseded by ISO 9000:2015.])ISO 9000:2005]]]

@Intelligent2013
Copy link
Contributor Author

@ronaldtse this markup creates footnote for reference in the text:

<eref type="inline" bibitemid="ISO_9000_2005" citeas="ISO 9000:2005...">ISO 9000:2005<fn reference="2">
						<p>Superseded by ISO 9000:2015.</p>
					</fn>
				</eref>

but we need footnote in the Bibliography/Normative References section:
(original PDF)
image

In references/bibitem there isn't data for Superseded by ISO 9000:2015.

@ronaldtse
Copy link
Contributor

@Intelligent2013 Ah, then is this a bug in Metanorma? This is a semantic issue: a footnote is not on the reference tag, it is supposed to be created inside the reference itself. Ping @opoudjis .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🏗 In progress
Development

No branches or pull requests

2 participants